[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

vitalybuka added a comment. This bot is broken after the patch https://lab.llvm.org/buildbot/#/builders/236/builds/1480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838

[Lldb-commits] [PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

vitalybuka added a comment. It breaks multiple bots. https://lab.llvm.org/buildbot/#/builders/37/builds/9960 https://lab.llvm.org/buildbot/#/builders/77/builds/13245 https://lab.llvm.org/buildbot/#/builders/169/builds/5409 https://lab.llvm.org/buildbot/#/builders/105/builds/19941 Can you please

[Lldb-commits] [PATCH] D104091: [lldb] Fix leak in test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3f904563ec9: [lldb] Fix leak in test (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104091: [lldb] Fix leak in test

vitalybuka updated this revision to Diff 351347. vitalybuka marked 2 inline comments as done. vitalybuka edited the summary of this revision. vitalybuka added a comment. ::Terminate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104091/new/

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I see comment on the D104091 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104093/new/ https://reviews.llvm.org/D104093

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

vitalybuka added inline comments. Comment at: lldb/source/Host/linux/HostInfoLinux.cpp:41 g_fields = new HostInfoLinuxFields(); } this still does not solve memory leak if HostInfoLinux::Initialize called twice CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104091: [NFC] Fix leak in test

vitalybuka created this revision. vitalybuka requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Test leaks if we run tools/lldb/unittests/Host/HostTests without --gtest_filter Also if we call HostInfoLinux::Initialize twice some

[Lldb-commits] [PATCH] D63854: NFC: Convert large lambda into method

This revision was automatically updated to reflect the committed changes. Closed by commit rL365708: NFC: Convert large lambda into method (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D63854: [NFC] Convert large lambda into method

vitalybuka created this revision. vitalybuka added a reviewer: pcc. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63854 Files: clang/lib/CodeGen/CGDecl.cpp

[Lldb-commits] [PATCH] D63854: [NFC] Convert large lambda into method

vitalybuka updated this revision to Diff 206771. vitalybuka added a comment. remove unrelated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63854/new/ https://reviews.llvm.org/D63854 Files: clang/lib/CodeGen/CGDecl.cpp