dzhidzhoev wrote:
@DavidSpickett thank you for the fixes!
https://github.com/llvm/llvm-project/pull/110837
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
> LGTM.
>
> Maybe @labath would like to take a last look at it before it lands.
I assume there are no more comments, so I'll merge it. I'm open for further
corrections.
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commi
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/99
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/110837
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/99
It was xfail'ed in de2ddc8f3146b. However, it passes on a buildbot
https://lab.llvm.org/staging/#/builders/195/builds/3988.
>From 092c1abb8de5e0bf3eaaa7758cc3dc3614c02b60 Mon Sep 17 00:00:00 2001
From: Vladi
https://github.com/dzhidzhoev approved this pull request.
https://github.com/llvm/llvm-project/pull/111033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/110837
>From a2c8b8b88fd47cbbdc32ca5f0f051391a9d77823 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Tue, 1 Oct 2024 13:14:25 +0200
Subject: [PATCH] [lldb][test] Provide proper path to LLVM utils in API t
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/110837
>From 8deb61b462964d08b4cc5d7f296b44ea4197f65b Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Tue, 1 Oct 2024 13:14:25 +0200
Subject: [PATCH] [lldb][test] Provide proper path to LLVM utils in API t
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From da63c0b7439358942b379776715a2369acc56593 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 01/11] [lldb][test] Support remote run of Shell tests
1
@@ -235,6 +235,8 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8)
set(LLDB_IS_64_BITS 1)
endif()
+set(LLDB_SHELL_TESTS_DISABLE_REMOTE OFF CACHE BOOL "Disable remote Shell tests
execution")
dzhidzhoev wrote:
> Also should this be LLDB_TEST_SHELL_TESTS_DISABLE_REMOTE? So
@@ -60,7 +60,8 @@ something like ``target.BreakpointCreateByName`` [#]_.
A good rule of thumb is to prefer shell tests when what is being tested is
relatively simple. Expressivity is limited compared to the API tests, which
means that you have to have a well-defined test scenar
dzhidzhoev wrote:
Rebased & added a line to documentation about the usage of API tests for remote
testing.
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From da63c0b7439358942b379776715a2369acc56593 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/9] [lldb][test] Support remote run of Shell tests
1.
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From da63c0b7439358942b379776715a2369acc56593 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/8] [lldb][test] Support remote run of Shell tests
1.
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
> Decide what to do with the remote test change but otherwise this LGTM.
Some other tests are unexpectedly passing on remote config, so they'll need
extra attention.
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
dzhidzhoev wrote:
Fixed
https://github.com/llvm
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/109961
>From 025276a52939c4091181dea5f633e443c908c4ef Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Mon, 16 Sep 2024 17:48:15 +0200
Subject: [PATCH 1/3] [lldb][test] Use tools from llvm instead of
compi
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
dzhidzhoev wrote:
https://lab.llvm.org/staging/#
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
dzhidzhoev wrote:
I thought it failed because of
dzhidzhoev wrote:
> Is there some tool that every bot is going to have to add an override for
> because it's not something in `/bin`?
AFAIK no. All these tools have llvm alternatives.
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits
dzhidzhoev wrote:
> A better version of my question, do you have a list of tools this effects, is
> it just the ones where you have modified lines in this PR?
>
> If so we probably have nothing to worry about.
These are the tools listed in util_names dictionary
https://github.com/llvm/llvm-pr
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/109961
>From 025276a52939c4091181dea5f633e443c908c4ef Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Mon, 16 Sep 2024 17:48:15 +0200
Subject: [PATCH 1/2] [lldb][test] Use tools from llvm instead of
compi
@@ -161,6 +165,11 @@ def getToolchainUtil(util_name):
}
utils = []
+# Required by API TestBSDArchives.py tests.
+# TODO don't forget to fix the test's Makefile when porting to mainline
dzhidzhoev wrote:
Thanks!
https://github.
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/109961
In #102185, toolchain detection for API tests has been rewritten to Python.
However, tools paths for tests are determined from compiler path.
Here tools are taken from `--llvm-tools-dir` dotest.py argument,
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -96,17 +98,105 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From b3fb433811a0f072823f03de7814cbc574c18dec Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 01/15] [lldb][test] Improve toolchain detection in
Mak
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
dzhidzhoev wrote:
> > > That bug shows we're not able to create a test for a very simple thing
> > > (an unaligned stack pointer) that works reliably for everyone.
> >
> >
> > Honestly, based on [#101710
> > (comment)](https://github.com/llvm/llvm-project/issues/101710#issuecomment-2291180977
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From b3fb433811a0f072823f03de7814cbc574c18dec Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 01/14] [lldb][test] Improve toolchain detection in
Mak
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 01/13] [lldb][test] Improve toolchain detection in
Mak
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 01/12] [lldb][test] Improve toolchain detection in
Mak
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -213,7 +229,7 @@ endif
LIMIT_DEBUG_INFO_FLAGS =
NO_LIMIT_DEBUG_INFO_FLAGS =
MODULE_DEBUG_INFO_FLAGS =
-ifneq (,$(findstring clang,$(CC)))
+ifeq ($(CCC), clang)
dzhidzhoev wrote:
Renamed it
https://github.com/llvm/llvm-project/pull/102185
__
@@ -96,16 +98,119 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,119 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,119 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 01/11] [lldb][test] Improve toolchain detection in
Mak
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -213,7 +229,7 @@ endif
LIMIT_DEBUG_INFO_FLAGS =
NO_LIMIT_DEBUG_INFO_FLAGS =
MODULE_DEBUG_INFO_FLAGS =
-ifneq (,$(findstring clang,$(CC)))
+ifeq ($(CCC), clang)
dzhidzhoev wrote:
Compiler type
https://github.com/llvm/llvm-project/pull/102185
___
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 1/6] [lldb][test] Improve toolchain detection in
Makef
@@ -102,15 +102,33 @@ endif
# If you change the defaults of CC, be sure to also change it in the file
# test/builders/builder_base.py, which provides a Python way to return the
# value of the make variable CC -- getCompiler().
-#
-# See also these functions:
-# o cxx_compiler
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 1/5] [lldb][test] Improve toolchain detection in
Makef
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/100836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 1/3] [lldb][test] Improve toolchain detection in
Makef
dzhidzhoev wrote:
> That bug shows we're not able to create a test for a very simple thing (an
> unaligned stack pointer) that works reliably for everyone.
Honestly, based on
https://github.com/llvm/llvm-project/issues/101710#issuecomment-2291180977, I'd
say that the mentioned test has a prob
dzhidzhoev wrote:
Now this is ready for review.
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -244,6 +244,7 @@ llvm_canonicalize_cmake_booleans(
LLVM_ENABLE_ZLIB
LLVM_ENABLE_SHARED_LIBS
LLDB_HAS_LIBCXX
+ LLDB_SHELL_TESTS_DISABLE_REMOTE
dzhidzhoev wrote:
Done
https://github.com/llvm/llvm-project/pull/95986
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From 8be2b2fece5291bf57d493464839d6a7cc999db1 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/7] [lldb][test] Support remote run of Shell tests
1.
@@ -165,6 +235,14 @@ def use_support_substitutions(config):
if config.cmake_sysroot:
host_flags += ["--sysroot={}".format(config.cmake_sysroot)]
+if config.enable_remote and config.has_libcxx:
+host_flags += [
+"-L{}".format(config.libcxx_li
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From 8be2b2fece5291bf57d493464839d6a7cc999db1 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/6] [lldb][test] Support remote run of Shell tests
1.
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 1/2] [lldb][test] Improve toolchain detection in
Makef
dzhidzhoev wrote:
Updated added dwp tool handling, to adopt changes from
e77ac42bccb8c26bbf4b74d8e92eb09e7fa1b218 and resolve merge conflict.
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH] [lldb][test] Improve toolchain detection in Makefile.r
dzhidzhoev wrote:
> Umm... could we move this logic to python, and then just pass the final tool
> paths (or whatever) into the makefile, like we did with the other patches
> (for `(HOST_)OS`, etc.) ?
Moved logic to Python, updated commit description.
https://github.com/llvm/llvm-project/pull
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From 5130b2af8c2a274d73a9d90a4a71d77d85ac0973 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH] [lldb][test] Improve toolchain detection in Makefile.r
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From b21f63e4376dd9c390abea72a1ebd5594652e681 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH] [lldb][test] Improve toolchain detection in Makefile.r
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From 5b3f0df1c35dc2f02d15da0e3222d6f5388e6f92 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 1/2] [lldb][test] Improve toolchain detection in
Makef
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/102185
This fix is based on a problem with cxx_compiler and cxx_linker macros on
Windows.
There was an issue with compiler detection in paths containing "icc". In such
case, Makefile.rules thought it was provided w
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
@labath are there any comments from you that haven't been resolved yet? I feel
that I may be missing something, but I don't see exactly what.
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@
https://github.com/dzhidzhoev approved this pull request.
https://github.com/llvm/llvm-project/pull/100487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4,16 +4,16 @@
target create -l "ls" /bin/ls
target list
-# CHECK: * target #0 (ls): /bin/ls
+# CHECK: * target #0 (ls): [[LS_PATH:.*]]
dzhidzhoev wrote:
Sorry, I was wrong here.
`target create` command accepts remote path. But `target list` prints full p
dzhidzhoev wrote:
> Though another way of thinking about it might be, I have a custom compiler
> setup but only intend to do host testing. This variable lets me tell the test
> runner not to assume I'm going to do any remote testing?
Yes, considering only Shell tests. By default, host testing
dzhidzhoev wrote:
> Ok I see what `LLDB_SHELL_TESTS_DISABLE_REMOTE` does but I don't get why.
> Perhaps you can show how a developer would:
>
> * Hit the problem that this option addresses
> * Apply the option
> * What problems it would solve and what that final build looks like
> * What the va
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From b747d2cf8d648e0dadda4adaaf2e0ef41d4ebd34 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/5] [lldb][test] Support remote run of Shell tests
1.
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From b747d2cf8d648e0dadda4adaaf2e0ef41d4ebd34 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/3] [lldb][test] Support remote run of Shell tests
1.
@@ -22,6 +24,55 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=None):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
@@ -22,6 +24,55 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=None):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
@@ -22,6 +24,55 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=None):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
@@ -4,16 +4,16 @@
target create -l "ls" /bin/ls
target list
-# CHECK: * target #0 (ls): /bin/ls
+# CHECK: * target #0 (ls): [[LS_PATH:.*]]
dzhidzhoev wrote:
> Do I understand correctly here that the path `/bin/ls` is given to target
> create, that program is
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From b747d2cf8d648e0dadda4adaaf2e0ef41d4ebd34 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/3] [lldb][test] Support remote run of Shell tests
1.
dzhidzhoev wrote:
> I'm not sure whether we need `LLDB_SHELL_TESTS_DISABLE_REMOTE`, can you
> explain how that would be used?
>
> Would I set up a build with all the other flags, do my remote testing, then
> set `LLDB_SHELL_TESTS_DISABLE_REMOTE=OFF` and run the shell tests locally,
> using th
@@ -138,7 +191,7 @@ def use_support_substitutions(config):
# Set up substitutions for support tools. These tools can be overridden
at the CMake
# level (by specifying -DLLDB_LIT_TOOLS_DIR), installed, or as a last
resort, we can use
# the just-built version.
-
@@ -52,6 +52,7 @@ def test_negative_indexing(self):
self.build()
self.validate_negative_indexing()
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
dzhidzhoev wrote:
I see the same function name/signature.
Btw, I'd recommend add
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
dzhidzhoev wrote:
> For comparison, my objdump output shows no symbol table:
>
> ```
> PS C:\workspace\
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
dzhidzhoev wrote:
```
$ F:/Users/vdzhidzhoev/temp/build-lldb-native/bin/clang.exe main.o -gdwarf -O0
-
dzhidzhoev wrote:
Update: fixed condition for remote execution.
Now this PR is ready for review.
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From b747d2cf8d648e0dadda4adaaf2e0ef41d4ebd34 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH] [lldb][test] Support remote run of Shell tests
1. This
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From d21c76b25e20e45b20f0f95bd7b4324fb5a19a81 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH] [lldb][test] Support remote run of Shell tests
1. This
@@ -1,3 +1,4 @@
+# XFAIL: target=x86_64-{{.*}}-windows{{.*}}
dzhidzhoev wrote:
> @dzhidzhoev would you be able to share the CMake configuration your Windows
> native CI is using? I'm having trouble spotting what's wrong with my local
> build.
For sure! Sorry,
1 - 100 of 235 matches
Mail list logo
