https://github.com/walter-erquinigo approved this pull request.
This LGTM
https://github.com/llvm/llvm-project/pull/91570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I second everything that Pavel says. I think this would be the best approach.
The existing frame var implementation is not that "smart", so it should be
practical to fully replace it with the new DIL in its first stage.
An additional consideration is that lldb-dap, whic
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/97675
CommandObjectBreakpoint has a harcoded list of languages for which exception
breakpoints can be enabled. I'm making this a bit more generic so that my Mojo
plugin can get this feature.
Basically, I'm ad
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/97675
>From 5d1a7254d1e1a541a7b901be0d3a84eab42474b2 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 4 Jul 2024 00:34:14 -0400
Subject: [PATCH 1/2] [LLDB] Support exception breakpoints for plugin-pr
@@ -319,6 +316,12 @@ class CommandObjectBreakpointSet : public
CommandObjectParsed {
error_context = "Unknown language type for exception breakpoint";
break;
default:
+ if (Language *languagePlugin = Language::FindPlugin(language)) {
--
walter-erquinigo wrote:
> And does this list include languages that are not plugin provided?
The hardcoded list in the file being changes includes C++ and Objc in its
various variants.
> I was wondering why only Objective C changed, but if the rest are not plugins
> then this makes sense.
Th
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/97675
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: walter erquinigo
Date: 2024-07-05T13:12:13-04:00
New Revision: 3bfc5167d9e49b9a53e364e8d8853fce543cca0f
URL:
https://github.com/llvm/llvm-project/commit/3bfc5167d9e49b9a53e364e8d8853fce543cca0f
DIFF:
https://github.com/llvm/llvm-project/commit/3bfc5167d9e49b9a53e364e8d8853fce543cca0f.di
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/97871
…lly registered languages
First of all, this is done to support exceptions for the Mojo language, but
it's done in a way that will benefit any other plugin language.
1. I added a new lldb-dap CLI argum
walter-erquinigo wrote:
This is a screenshot of how it's looking for me on VSCode.
https://github.com/llvm/llvm-project/pull/97871
___
lldb-commits mail
walter-erquinigo wrote:
> Exception Breakpoints are created by the static method
> LanguageRuntime::CreateExceptionBreakpoint. So they don't require a process.
Indeed, but let me elaborate. What I need is a method that doesn't require a
process that could tell me if a certain language can sup
@@ -58,10 +58,17 @@ DAP::DAP()
DAP::~DAP() = default;
+/// Return string with first character capitalized.
+static std::string capitalize(llvm::StringRef str) {
+ if (str.empty())
+return "";
+ return ((llvm::Twine)llvm::toUpper(str[0]) + str.drop_front()).str();
+}
+
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/97871
>From aa2ad3b675f67581dde07a476725d2574fc6e7da Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 5 Jul 2024 20:30:44 -0400
Subject: [PATCH] [lldb-dap] Support throw and catch exception breakpoin
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/98089
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
This is a very benign change, so I'll be merging it. Happy to make change
post-merge if anyone provides any feedback.
https://github.com/llvm/llvm-project/pull/97871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/97871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,91 @@
+"""
+Test lldb-dap setBreakpoints request
+"""
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+import lldbdap_testcase
+from lldbsuite.test import lldbutil
+
+
+class TestDAP_stopEvents(lldbdap_testcase.DAPTestCaseBase):
+@s
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/98703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/98703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1710,6 +1710,8 @@ void request_initialize(const llvm::json::Object
&request) {
body.try_emplace("supportsLogPoints", true);
// The debug adapter supports data watchpoints.
body.try_emplace("supportsDataBreakpoints", true);
+ // Putting version string. Note: this is
Author: walter erquinigo
Date: 2024-07-15T23:00:17-04:00
New Revision: 27b2f4f861b8aeeabc4eb1a97649062de8fa3992
URL:
https://github.com/llvm/llvm-project/commit/27b2f4f861b8aeeabc4eb1a97649062de8fa3992
DIFF:
https://github.com/llvm/llvm-project/commit/27b2f4f861b8aeeabc4eb1a97649062de8fa3992.di
walter-erquinigo wrote:
@kevinfrei , I'm so sorry to tell you that I have reverted this patch. The
revert commit is 27b2f4f861b8aeeabc4eb1a97649062de8fa3992 and I left some notes
there, which I also copy here:
The patch #98344 causes a crash in LLDB when parsing some files like
`numpy.libs/l
walter-erquinigo wrote:
@kevinfrei , I'm glad I can be of help to you! Let me know if you want me to
try out your next iteration of this PR on my device.
https://github.com/llvm/llvm-project/pull/98344
___
lldb-commits mailing list
lldb-commits@lists.
walter-erquinigo wrote:
This LGTM, although I'd rather have someone like @clayborg taking a look
https://github.com/llvm/llvm-project/pull/99362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
walter-erquinigo wrote:
This is very exciting!
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
What about trying to use a python builtin like
https://docs.python.org/3/library/multiprocessing.html#multiprocessing.active_children?
https://github.com/llvm/llvm-project/pull/90223
___
lldb-commits mailing list
lldb-commits@l
walter-erquinigo wrote:
@JDevlieghere , do you know if it's possible to add python dependencies
somewhere for lldb tests?
https://github.com/llvm/llvm-project/pull/90223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/walter-erquinigo approved this pull request.
lgtm.
It would be nice if new UI features could be added in the typescript code of
lldb-dap, so that all users benefit from them.
https://github.com/llvm/llvm-project/pull/90799
___
lldb-
https://github.com/walter-erquinigo approved this pull request.
makes sense to me
https://github.com/llvm/llvm-project/pull/87649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I thought you were meaning UI changes via the fblldb extension, but if you are
modying your fork of VSCode, there's nothing to be done then.
https://github.com/llvm/llvm-project/pull/90799
___
lldb-commits mailing list
lldb-com
https://github.com/walter-erquinigo approved this pull request.
This all makes sense to me. Thank you!
https://github.com/llvm/llvm-project/pull/91591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/walter-erquinigo approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/91688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/92028
Otherwise the build step fails due to missing dependencies.
>From b065234db18dd726b4e39a98ac0c360e052fe438 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 13 May 2024 22:39:47 +0200
Subject:
@@ -335,6 +335,37 @@ def cleanup():
response["success"], "attach failed (%s)" %
(response["message"])
)
+def attach_by_port(
walter-erquinigo wrote:
could you just extend the `def attach` function? Having a totally new entry
@@ -0,0 +1,137 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+import shutil
+impor
@@ -762,9 +765,31 @@ void request_attach(const llvm::json::Object &request) {
// Disable async events so the attach will be successful when we return
from
// the launch call and the launch will happen synchronously
g_dap.debugger.SetAsync(false);
-if (core_file
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/92137
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I don't think anything has changed on VSCode proper. I've just verified I have
the same experience as you. Given what you said, I'm in favor of reverting this
or at least gating this feature under a json initialization option until the
original author can look at this.
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/92028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
lgtm!
https://github.com/llvm/llvm-project/pull/92320
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/92345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/92398
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,146 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
@@ -1572,6 +1572,15 @@ def findBuiltClang(self):
return os.environ["CC"]
+def getBuiltinServerTool(self, server_tool):
+# Tries to find simulation/lldb-server/gdbserver tool at the same
folder as the lldb.
+lldb_dir = os.path.dirname(lldbtest_conf
@@ -676,6 +676,8 @@ void request_attach(const llvm::json::Object &request) {
auto arguments = request.getObject("arguments");
const lldb::pid_t pid =
GetUnsigned(arguments, "pid", LLDB_INVALID_PROCESS_ID);
+ const auto port = GetUnsigned(arguments, "port", LLDB_INVAL
@@ -0,0 +1,146 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
@@ -0,0 +1,146 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/92416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
beautiful
https://github.com/llvm/llvm-project/pull/92428
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
That's a great idea. There's no such `dap` category at the moment, but it would
be nice if such category is created as part of the ongoing lldb-dap test fixes.
https://github.com/llvm/llvm-project/pull/92416
___
lldb-commits ma
walter-erquinigo wrote:
I'm okay with anything that ensures hovering is fast.
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Thanks, @labath , for chiming in. I actually agree with all your points.
https://github.com/llvm/llvm-project/pull/91570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/92726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Pretty nice! This will be useful for Mojo as well
https://github.com/llvm/llvm-project/pull/92979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/90580
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Thanks for doing this.
Btw, that was a clever way of testing this functionality.
https://github.com/llvm/llvm-project/pull/93534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
@@ -103,7 +103,9 @@ void DAP::SendJSON(const llvm::json::Value &json) {
SendJSON(json_str);
if (log) {
-*log << "<-- " << std::endl
+auto now = std::chrono::duration(
+std::chrono::system_clock::now().time_since_epoch());
walter-erquinigo w
https://github.com/walter-erquinigo approved this pull request.
sounds good then!
https://github.com/llvm/llvm-project/pull/93540
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -749,9 +752,30 @@ void request_attach(const llvm::json::Object &request) {
// Disable async events so the attach will be successful when we return
from
// the launch call and the launch will happen synchronously
g_dap.debugger.SetAsync(false);
-if (core_file
@@ -0,0 +1,142 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/94494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Jonas' suggestion is pretty good. Please do that. Probably something like this
would work
`
def collect_console(timeout_secs=10, check_interval_secs=1):
...
`
Then you can just update every caller of this function to just do
`collect_console()`
https://github.com/llv
@@ -467,5 +467,5 @@ def test_terminate_commands(self):
# Once it's disconnected the console should contain the
# "terminateCommands"
self.dap_server.request_disconnect(terminateDebuggee=True)
-output = self.collect_console(duration=1.0)
+
@@ -75,6 +75,6 @@ def
test_command_directive_abort_on_error_attach_commands(self):
attachCommands=["?!" + command_quiet, "!" +
command_abort_on_error],
expectFailure=True,
)
-full_output = self.collect_console(duration=1.0)
+ful
@@ -47,7 +47,7 @@ def do_test_abort_on_error(
postRunCommands=commands if use_post_run_commands else None,
expectFailure=True,
)
-full_output = self.collect_console(duration=1.0)
+full_output = self.collect_console(timeout_secs=1.
@@ -235,5 +235,5 @@ def test_terminate_commands(self):
# Once it's disconnected the console should contain the
# "terminateCommands"
self.dap_server.request_disconnect(terminateDebuggee=True)
-output = self.collect_console(duration=1.0)
+
@@ -200,7 +200,7 @@ def test_commands(self):
# Get output from the console. This should contain both the
# "exitCommands" that were run after the second breakpoint was hit
# and the "terminateCommands" due to the debugging session ending
-output
@@ -337,7 +337,7 @@ def test_commands(self):
# Get output from the console. This should contain both the
# "exitCommands" that were run after the second breakpoint was hit
# and the "terminateCommands" due to the debugging session ending
-output
walter-erquinigo wrote:
@mbucko , could you request commit access to Chris Latner?
```
We grant commit access to contributors with a track record of submitting high
quality patches. If you would like commit access, please send an email to
[Chris](mailto:clattner%40llvm.org) with your GitHub u
walter-erquinigo wrote:
I'll review this today or tomorrow. Thanks for all the activity!
https://github.com/llvm/llvm-project/pull/91570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/70157
This effectively moves a few functions from protected to public. In any case,
for the sake of having a cleaner SymbolFileDWARF API, it's better if it's not a
friend of a one of its consumers, DWARFASTPa
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/70157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -325,15 +323,46 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
-protected:
typedef llvm::DenseMap DIEToTypePtr;
- typedef llvm::DenseMap
- DIEToVariableSP;
+
+ virtual DIEToTypePtr &GetDIEToType() { return m_die_to_type; }
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/70157
>From 98c80871a753c58a49e8ba0d535e03e99d633109 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Tue, 24 Oct 2023 22:32:38 -0400
Subject: [PATCH 1/2] [LLDB][NFC] Remove DWARFASTParserClang as friend
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/70157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -396,8 +398,22 @@ Symbols::LocateExecutableSymbolFile(const ModuleSpec
&module_spec,
}
}
}
-
- return LocateExecutableSymbolFileDsym(module_spec);
+ FileSpec dsym_bundle = LocateExecutableSymbolFileDsym(module_spec);
+ if (dsym_bundle)
+return dsym_bundle
@@ -396,8 +398,22 @@ Symbols::LocateExecutableSymbolFile(const ModuleSpec
&module_spec,
}
}
}
-
- return LocateExecutableSymbolFileDsym(module_spec);
+ FileSpec dsym_bundle = LocateExecutableSymbolFileDsym(module_spec);
+ if (dsym_bundle)
+return dsym_bundle
https://github.com/walter-erquinigo commented:
pretty nice feature!
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -196,13 +196,15 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS)
MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and
lldb_private namespaces")
# Pull out the various lldb libraries linked into liblldb, these will be used
- # when looking for symbols to extract.
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71087
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/71087
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -196,13 +196,15 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS)
MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and
lldb_private namespaces")
# Pull out the various lldb libraries linked into liblldb, these will be used
- # when looking for symbols to extract.
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71143
DummySyntheticFrontEnd is implementing correctly CalculateNumChildren but not
MightHaveChildren, where instead of delegating its action, it was returning
true.
This fixes that simple bug.
>From 57d19f
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/71143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71455
- [LLDB][easy] Fix a bug in DummySyntheticFrontEnd
- [LLDB] Don't forcefully initialize the process trace plugin
>From 57d19fdd476b293a87f1c14b743ba636350af7a1 Mon Sep 17 00:00:00 2001
From: walter erqu
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71455
>From d877ef80bbaa62afed2c7656c5ff6e84a8628786 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 6 Nov 2023 17:57:45 -0500
Subject: [PATCH] [LLDB] Don't forcefully initialize the process trace p
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71828
lldb's AppleDWARFIndex is created with a few `llvm::AppleAcceleratorTable`
variables, but they only hold pointers to the underlying data, which doesn't
prevent the data owner (lldb's DataBufferHeap) fro
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/71843
When this option is enabled, display names of stack frames are generated using
the `${function.name-with-args}` formatter instead of simply calling
`SBFrame::GetDisplayFunctionName`. This makes lldb-dap
walter-erquinigo wrote:
The changes seem very trivial to me, so please let me know if there's something
else I should do or be aware of.
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
walter-erquinigo wrote:
These asserts might not always pass? I don't know if it's guaranteed that if
one of those sections is present, then the rest of them are as well.
ht
@@ -187,3 +188,19 @@ def test_stackTrace(self):
self.assertEquals(
0, len(stackFrames), "verify zero frames with startFrame out of
bounds"
)
+
+@skipIfWindows
walter-erquinigo wrote:
I think all vscode tests skip on windows...
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 980f1e0ceb43da5f4d504f7ed04c3abb591e406d Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 7b9b5897e2e801d7bc97639ed302b885481659bd Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 2f3841dc6d68f755b11f6677ed2d034a88a297c8 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
1 - 100 of 824 matches
Mail list logo
