[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

stella.stamenova added a comment. In D101128#2831098 , @wallace wrote: > I'm reverting it asap Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 _

Re: [Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

I'm reverting it asap Il giorno lun 21 giu 2021 alle ore 10:48 Stella Stamenova via Phabricator < revi...@reviews.llvm.org> ha scritto: > stella.stamenova added a comment. > > @wallace : Your most recent change to comment out > ProgressEventThreadFunction is causing warnings to be generated when

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

stella.stamenova added a comment. @wallace : Your most recent change to comment out ProgressEventThreadFunction is causing warnings to be generated when building with clang. Please have a look: /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4685c0fb3a: [lldb-vscode] only report long running progress events (authored by wallace, committed by Walter Erquinigo ). Reposit

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added a comment. https://reviews.llvm.org/P8265 is a sample DAP output with these messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 ___ lldb-comm

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 350419. wallace added a comment. Addressed the comments except for the "static function that we can call and remove the passing of the instance variable for the report callback all over to the event classes". That's a little bit hard to achieve because the c

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The only last nit is we are passing the report progress callback around all over the place. I think it would be nicer to just make a static function that we can call and remove t

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 346335. wallace added a comment. Simplified the constructors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 Files: lldb/tools/lldb-vscode/ProgressEvent.cpp lldb/

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/ProgressEvent.h:32 + ProgressEvent(uint64_t progress_id, llvm::StringRef message, +llvm::Optional percentage); clayborg wrote: > Why is there an optional percentage for a start e

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:143-148 + // The event finished before we were able to report it. + if (!m_start_event.Reported() &&

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342754. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 Files: lldb/tools/lldb-vscode/ProgressEvent.cpp lldb/tools/lldb-vscode/Progr

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342650. wallace marked 12 inline comments as done. wallace added a comment. Address all comments - now the reporting timing conditions are in ProgressEvent, which simplifies the other classes - removed the progressInvalid enum by making sure only valid Progr

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:35 + + if (m_event_type == progressStart) +m_message = message; ==

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342386. wallace marked 12 inline comments as done. wallace added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 Files: lldb/tools/l

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:89 + m_start_event_timestamp >= + std::chrono::seconds(3); +} clayborg wrote: > The patch description says 5 seconds, here

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:89 + m_start_event_timestamp >= + std::chrono::

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When the number of shared libs is massive, there could be hundreds of thousands of short lived progress events sent to the IDE, which makes it irresponsi