This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG66902a32c838: [StopInfoMachException] Summarize arm64e
BLRAx/LDRAx auth failures (authored by vsk).
Repository:
rG LLVM Github Monorepo
CHANGES S
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
Apologies, I forgot about this for way too long. I don't think Omair is going
to object anyway so let's get this in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
vsk updated this revision to Diff 360180.
vsk added a comment.
Drop unneeded braces in switch cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102428/new/
https://reviews.llvm.org/D102428
Files:
lldb/include/lldb/Core/Address.h
lldb/includ
DavidSpickett added a reviewer: omjavaid.
DavidSpickett added a comment.
Apologies, I missed the ping. A couple of minor comments otherwise this looks
good to me.
@omjavaid Should take a look too as he's doing/did the PAC work for Arm Linux.
I figure this can go in for Mac and be made generic l
vsk added a comment.
Friendly ping.
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:126
+Address brk_address;
+if (!target.ResolveLoadAddress(fixed_bad_address, brk_address))
+ return false;
DavidSpickett wrote:
> vsk wrot
DavidSpickett added inline comments.
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:126
+Address brk_address;
+if (!target.ResolveLoadAddress(fixed_bad_address, brk_address))
+ return false;
vsk wrote:
> DavidSpickett wrote
vsk added inline comments.
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:126
+Address brk_address;
+if (!target.ResolveLoadAddress(fixed_bad_address, brk_address))
+ return false;
DavidSpickett wrote:
> vsk wrote:
> > Davi
vsk updated this revision to Diff 345940.
vsk added a comment.
Address review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102428/new/
https://reviews.llvm.org/D102428
Files:
lldb/include/lldb/Core/Address.h
lldb/include/lldb/Core/D
DavidSpickett added a comment.
I think some of my questions are too detailed for this initial patch, I'm sure
we can improve the diagnostics over time as situations come up. Glad to see
this being upstreamed.
Not very knowledgeable on Mach specifics so I'll leave the final review to
others.
vsk added a comment.
Thanks for the review!
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/ptrauth_diagnostics/BLRAA_error/blraa.c:19
+
+// Before:
+#if 0
DavidSpickett wrote:
> What is the purpose of the `// Before:` blocks here? Simply to gi
vsk updated this revision to Diff 345513.
vsk added a comment.
Address code review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102428/new/
https://reviews.llvm.org/D102428
Files:
lldb/include/lldb/Core/Address.h
lldb/include/lldb/C
DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.
I think the test files should go in
`test/API/functionalities/ptrauth_diagnostics/` instead.
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/ptrauth_diagnostics/BLRAA_error/blraa.c:1
vsk created this revision.
vsk added reviewers: JDevlieghere, jingham, jasonmolenda.
Herald added subscribers: omjavaid, kristof.beyls.
vsk requested review of this revision.
Herald added a project: LLDB.
Upstream lldb support for summarizing BLRAx and LDRAx auth failures.
rdar://41615322
Repos
13 matches
Mail list logo
