[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

2021-05-17 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp:409 + // static MyClass *__lldb_expr_result_ptr = &c; // Points to stack. + // __lldb_expr_result_ptr(__lldb_expr_result_ptr); + // } // End of exp

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

2021-05-17 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp:409 + // static MyClass *__lldb_expr_result_ptr = &c; // Points to stack. + // __lldb_expr_result_ptr(__lldb_expr_result_ptr); + // } // End of expressio

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

2021-05-17 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:2026 + i = call->eraseFromParent(); + continue; +} I do wish we had a better way to do the iterate-while-erase algorithm

[Lldb-commits] [PATCH] D102624: [lldb] Optimize expressions

2021-05-17 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. At the moment we codegen or interpret the IR in exactly the way as it is generated by Clang. This patch runs th