This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG251a5d9d5239: [lldb/API] Expose triple for SBProcessInfo.
(authored by brucem).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103375/new/
https://reviews.llvm.org/D103375
___
teemperor added inline comments.
Comment at: lldb/source/API/SBProcessInfo.cpp:191
+ // the string
+ triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString();
+}
brucem wrote:
> teemperor wrote:
> > You need to 'instrument' these func
brucem added inline comments.
Comment at: lldb/source/API/SBProcessInfo.cpp:191
+ // the string
+ triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString();
+}
teemperor wrote:
> You need to 'instrument' these functions. there is a too
teemperor added inline comments.
Comment at: lldb/source/API/SBProcessInfo.cpp:191
+ // the string
+ triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString();
+}
You need to 'instrument' these functions. there is a tool called `lldb-i
brucem created this revision.
brucem added a reviewer: lldb-commits.
brucem requested review of this revision.
Herald added a project: LLDB.
This is present when doing a `platform process list` and is
tracked by the underlying code. To do something like the
process list via the SB API in the futur
