brucem added a comment.
I had requested it and got it a short bit ago. Looks like I landed it
successfully. Thanks for the review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103381/new/
https://reviews.llvm.org/D103381
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG36597e4719e9: [lldb] Fix typos. NFC. (authored by brucem).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
teemperor added a comment.
I assume you don't have requested commit access yet (?) so I'm going to land
this for you. Thanks for the patch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103381/new/
https://reviews.llvm.org/D103381
brucem updated this revision to Diff 348714.
brucem added a comment.
Mark as NFC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103381/new/
https://reviews.llvm.org/D103381
Files:
lldb/docs/design/overview.rst
lldb/docs/resources/test.rst
brucem updated this revision to Diff 348713.
brucem added a comment.
Remove incorrect change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103381/new/
https://reviews.llvm.org/D103381
Files:
lldb/docs/design/overview.rst
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM but could you split out the non-NFC change (and then you can also mark
this whole commit as NFC). I'm just going to accept this module that change.
Comment at:
brucem created this revision.
Herald added a reviewer: shafik.
brucem requested review of this revision.
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D103381
Files:
lldb/docs/design/overview.rst
lldb/docs/resources/test.rst
