This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG64576a1be887: [lldb][NFC] Refactor name to index maps in
Symtab (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
bulbazord updated this revision to Diff 350685.
bulbazord added a comment.
Rename function :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103652/new/
https://reviews.llvm.org/D103652
Files:
lldb/include/lldb/Symbol/Symtab.h
lldb/source/Symbo
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Some small rename I forgot to point out, but LGTM modulo that rename. Thanks
for cleaning this up!
Comment at: lldb/include/lldb/Symbol/Symtab.h:186
private:
+ Uniqu
bulbazord updated this revision to Diff 350405.
bulbazord added a comment.
Remove unused line of code that I forgot to remove previously
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103652/new/
https://reviews.llvm.org/D103652
Files:
lldb/inclu
bulbazord updated this revision to Diff 350404.
bulbazord added a comment.
Address feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103652/new/
https://reviews.llvm.org/D103652
Files:
lldb/include/lldb/Symbol/Symtab.h
lldb/source/Symbol/
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Only have some comments about the way `FindFunctionSymbols` is now implemented,
but otherwise this LGTM.
Comment at: lldb/include/lldb/Symbol/Symtab.h:177
bulbazord created this revision.
bulbazord added reviewers: teemperor, JDevlieghere.
Herald added a subscriber: arphaman.
bulbazord requested review of this revision.
Herald added a project: LLDB.
The various maps in Symtab lead to some repetative code. This should
improve the situation somewhat.
