[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf23b829a2635: Fixed use of -o and -k in LLDB under Windows when statically compiled with… (authored by PatriosTheGreat, committed by DavidSpickett).

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Thanks for review! Could you or someone else take this commit to master? I don't have a commit permissions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/test/API/python_api/file_handle/TestFileHandle.py:920 +self.assertTrue(re.search(r'Show a list of all debugger commands', ou

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Friendly ping =) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat marked 2 inline comments as done. PatriosTheGreat added a comment. Sorry for delay from my side also CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat updated this revision to Diff 371002. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 Files: lldb/bindings/interface/SBDebugger.i lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Core/Debugger.h lldb/source/API/SBDebu

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry for the delay on this! Feel free to ping sooner if this gets stuck again. I think just passing a string here seems fine, but maybe we could let the function just take a C

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor added a comment. In D104413#2952057 , @PatriosTheGreat wrote: > Should I send this somehow back to review? Nope, this is (as it should be) in the review queue but I just didn't get around to this yet. Sorry for the delay, I'll try to take a l

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Should I send this somehow back to review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat updated this revision to Diff 353875. PatriosTheGreat added a comment. Hi everyone. Thanks for review. In order to move new method code to Debugger class I also had to move there SetInputFile(lldb::FileSP file) method. After I did that -- the reproducer tests started to fail. If

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

shafik added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:392 + + if (result.Fail()) { +return result; What case is this catching? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ http

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Could you move this function into the `Debugger` class and just make `SBDebugger` forward to that function? We usually keep the `SB*` classes as thin wrappers that only contain

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: teemperor, jarin. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Right now if the LLDB is compiled under the windows with static vcruntime library, th