[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid abandoned this revision. nealsid added a comment. Not needed with existing test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437 ___ lldb-commi

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid added a comment. Agreed, it looks like there's plenty of test coverage for this scenario, so I'll revert this patch - sorry about that. I'm working on removing the wchar/char preprocessor logic in Editline.cpp so I'll verify the existing coverage before sending that for review. Thanks

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid added a comment. Thanks to both of you for this! I’m traveling for a few days but will be able to take a look towards the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

teemperor added a comment. In D104437#2825559 , @nealsid wrote: > Ah, my grep/find skills clearly failed me :) > > Yeah, those tests are exactly the same scenarios. However, if I understand > correctly, don't they use the API? I wanted to add some cover

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

jingham added a comment. It's quite common to use the lldbtest.TestBase.runCmd or lldbtest.TestBase.expect to test command line commands in the API tests. The latter has expect-like results checking which makes writing these checks easy. Even if you are testing a command-line command, drivin

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid added a comment. Ah, my grep/find skills clearly failed me :) Yeah, those tests are exactly the same scenarios. However, if I understand correctly, don't they use the API? I wanted to add some coverage for the shell because I'm making changes to the Editline wrapper, and the existing t

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for writing tests, it's really appreciated! FWIW, I think that you can just check in new tests without having to go through a full review (unless you do want feedback fo

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid updated this revision to Diff 352612. nealsid added a comment. Herald added a subscriber: JDevlieghere. Add newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437 Files: lldb/test/Shell/Breakp

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid created this revision. nealsid added a reviewer: LLDB. nealsid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This small patch adds a test for functions & lldb commands with unicode characters in them. Repository: rG LLVM Gith