[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett added a comment. I was going to say we only would need to remove the assert for this one: void CommandReturnObject::SetError(const Status , const char *fallback_error_cstr) { Since SetError checks that the `char *` is not null in the API

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

teemperor added a comment. In D104525#2830025 , @DavidSpickett wrote: > Yeah good point, I can do that. I'm gonna go over the remaining SetStatus > calls first, then I'll look at it. Thank you, really appreciated! Repository: rG LLVM Github

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett added a comment. Yeah good point, I can do that. I'm gonna go over the remaining SetStatus calls first, then I'll look at it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104525/new/ https://reviews.llvm.org/D104525

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

teemperor added a comment. LGTM, thanks for cleaning this up. If we're anyway signing up @DavidSpickett for refactoring duty: `CommandReturnObject::SetError(llvm::StringRef error_str)` is clearly the same method as `CommandReturnObject::AppendError`, so one of those probably should go the way

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12ae3cb7ba53: [lldb] Assert that CommandResultObject error messages are not empty (authored by DavidSpickett). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett updated this revision to Diff 353310. DavidSpickett added a comment. Use !empty instead of size. All tests passing on X86 and AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104525/new/ https://reviews.llvm.org/D104525 Files:

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good, if this already passes all tests/etc (ie: there actually aren't any callers passing empty strings/non-failed errors/etc) Comment at:

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett created this revision. Herald added a subscriber: inglorion. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The intention is now that AppendError/SetError/AppendRawError only be called with some message to