[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6b64612bd92: [lldb/Interpreter] Fix session-save-on-quit when using ^D (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

mib updated this revision to Diff 354988. mib added a comment. Address @jingham comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038 Files: lldb/source/Commands/CommandObjectQuit.cpp lldb/source/C

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Shouldn't have also said accepted yet... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. One nit about the handling of colors. Comment at: lldb/source/Core/Debugger.cpp:611 + if (cmd_interpreter.GetSaveSessionOnQuit()) { +CommandReturnObject result(/*color

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

mib updated this revision to Diff 354962. mib marked 2 inline comments as done. mib added a comment. Address @jingham, @JDevlieghere & @shafik comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038 Fil

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

shafik added inline comments. Comment at: lldb/source/Core/Debugger.cpp:611 + if (cmd_interpreter.GetSaveSessionOnQuit()) { +CommandReturnObject result(/*colors*/ true); +cmd_interpreter.SaveTranscript(result); `/*colors=*/true` Repository: rG LLVM G

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2977 + result.SetStatus(eReturnStatusSuccessContinuingResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", Why `eReturnStatusSuccessCont

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

jingham added a comment. Maybe a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

mib created this revision. mib added reviewers: JDevlieghere, teemperor. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. Previously, when `interpreter.save-session-on-quit` was enabled, lldb would save the session transcript only when runn