DavidSpickett created this revision.
Herald added subscribers: danielkiss, kristof.beyls.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This is implemented using the QMemTags packet, as specified
by GDB in:
https://sourcewar
omjavaid added inline comments.
Comment at:
lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56
# Run the packet stream
context = self.expect_gdbremote_sequence()
self.assertIsNotNone(context)
This test is s
omjavaid added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1517
+
+ llvm::Expected> repeated_tags_or_err =
+ details->manager->RepeatTagsForRange(*unpacked_tags_or_err, range);
We unpack, repeat and then repack. Can
DavidSpickett added inline comments.
Comment at:
lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56
# Run the packet stream
context = self.expect_gdbremote_sequence()
self.assertIsNotNone(context)
omjavaid
DavidSpickett added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1517
+
+ llvm::Expected> repeated_tags_or_err =
+ details->manager->RepeatTagsForRange(*unpacked_tags_or_err, range);
omjavaid wrote:
> We unpack, repe
DavidSpickett updated this revision to Diff 358539.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105180/new/
https://reviews.llvm.org/D105180
Files:
lldb/include/lldb/Host/common/NativeProcessProtocol.h
l
DavidSpickett updated this revision to Diff 358976.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105180/new/
https://reviews.llvm.org/D105180
Files:
lldb/include/lldb/Host/common/NativeProcessProtocol.h
l
omjavaid added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1550
+size_t tags_written = tags_vec.iov_len;
+assert(tags_written && (tags_written <= num_tags));
+
This assertion suggests something went wrong on ptrac
omjavaid added inline comments.
Comment at:
lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56
# Run the packet stream
context = self.expect_gdbremote_sequence()
self.assertIsNotNone(context)
omjavaid wrote
DavidSpickett added inline comments.
Comment at:
lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56
# Run the packet stream
context = self.expect_gdbremote_sequence()
self.assertIsNotNone(context)
omjavaid
omjavaid added inline comments.
Comment at:
lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56
# Run the packet stream
context = self.expect_gdbremote_sequence()
self.assertIsNotNone(context)
DavidSpickett
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
@DavidSpickett Lets merge this patch series (if it is working on your desk) but
we should add information in LLDB wiki or any other appropriate place about how
to reliably test mte feature
DavidSpickett added a comment.
Great.
The QEMU testing docs https://lldb.llvm.org/use/qemu-testing.html include MTE
options. Apart from having a compatible toolchain there's no difference to SVE.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D10518
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7d27230de333: [lldb][AArch64] Add memory tag writing to
lldb-server (authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
14 matches
Mail list logo