omjavaid created this revision.
omjavaid added a reviewer: DavidSpickett.
Herald added subscribers: danielkiss, kristof.beyls.
omjavaid requested review of this revision.
This patch adds a helper function to test target architecture is AArch64 or
not. This also tightens isAArch64* helpers by addi
DavidSpickett added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296
+"""Returns true if the architecture is AArch64."""
+return self.getArchitecture().lower() in ["aarch64"]
+
This can be:
```
return self.getArchi
omjavaid added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296
+"""Returns true if the architecture is AArch64."""
+return self.getArchitecture().lower() in ["aarch64"]
+
DavidSpickett wrote:
> This can be:
> ```
DavidSpickett added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296
+"""Returns true if the architecture is AArch64."""
+return self.getArchitecture().lower() in ["aarch64"]
+
omjavaid wrote:
> DavidSpickett wrote
omjavaid added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296
+"""Returns true if the architecture is AArch64."""
+return self.getArchitecture().lower() in ["aarch64"]
+
DavidSpickett wrote:
> omjavaid wrote:
> >
omjavaid updated this revision to Diff 357837.
omjavaid added a comment.
This fixes issue raised in last rev.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105483/new/
https://reviews.llvm.org/D105483
Files:
lldb/packages/Python/lldbsuite/test/lldbtest.py
lldb/test/API/functionalit
DavidSpickett added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105483/new/
https://reviews.llvm.org/D105483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rG10f5e08a7124: [LLDB] Testsuite: Add helper to check for
AArch64 target (authored by omjavaid).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revi
