[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 created this revision. augusto2112 added reviewers: jasonmolenda, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On mach-O, if an object file is eligible to be in the shared cache, it cannot have data read

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. Hm there's no phab action which says "reject approach" :) the perf impact of forcing all reads to be out of memory would be dramatically bad for a remote system debug session, this can't be done. If there is a specific caller that must use live memory even for a s

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. I should add — I also don’t think this will fix the bug you’re working on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 ___ lld

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. I do like the debug-lldb check that the file cache read matches the live memory part. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 ___

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 added a comment. Hi Jason, I could place this check on the caller, but I think here is the right place for it, maybe I can convince you. > the perf impact of forcing all reads to be out of memory would be > dramatically bad for a remote system debug session, this can't be done. On

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

vsk added a comment. Hey Augusto, thanks for tackling this, I'm just now slowly paging things in. Is this a correct statement of the problem: LLDB is failing to disable its file cache optimization when reading writable segments (say, __DATA) from a MachO sourced from the shared cache? If that'

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. Sorry for the delay in replying, I needed to think & look at this a bit. In D106584#2900239 , @augusto2112 wrote: > Hi Jason, > > I could place this check on the caller, but I think here is the right place > for it, maybe

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. In D106584#2902200 , @jasonmolenda wrote: > > In D106584#2900239 , @augusto2112 > wrote: > >> Hi Jason, >> >> At least that we can keep then :) Do you think it's should be a cra

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 added a comment. In D106584#2901529 , @vsk wrote: > Hey Augusto, thanks for tackling this, I'm just now slowly paging things in. > > Is this a correct statement of the problem: LLDB is failing to disable its > file cache optimization when rea

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 updated this revision to Diff 361991. augusto2112 added a comment. Keep only filecache and live memory equality assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Files: lldb/include/