This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG602497d672ca: [trace] [intel pt] Create a process
trace save
wallace accepted this revision.
wallace added a comment.
good job
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107669/new/
https://reviews.llvm.org/D107669
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
hanbingwang updated this revision to Diff 366713.
hanbingwang marked an inline comment as not done.
hanbingwang added a comment.
merge into one line: "json_module["loadAddress"] = oss.str();"
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107669/new/
https://reviews.llvm.org/D107669
hanbingwang updated this revision to Diff 366690.
hanbingwang added a comment.
*TraceIntelPT.h, TraceIntelPT.cpp:
-add new function GetLiveProcess()
*TraceIntelPTSessionSaver.h, TraceIntelPTSessionSaver.cpp
- the function SaveToDisk() no longer requires "m_live_process" as input param.
wallace requested changes to this revision.
wallace added a comment.
This revision now requires changes to proceed.
Almost there. Many cosmetic changes but the logic is all good.
Comment at: lldb/include/lldb/Target/Trace.h:178
+ /// \param[in] tid
/// The thread in
hanbingwang updated this revision to Diff 366151.
hanbingwang edited the summary of this revision.
hanbingwang added a comment.
Herald added a subscriber: pengfei.
*TraceSessionSaver.h, TraceSessionSaver.cpp:
-move BuildModulesSection(), BuildThreadsSection(), BuildProcessesSection(),
wallace requested changes to this revision.
wallace added a comment.
This revision now requires changes to proceed.
discussed offline of some improvements to make
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107669/new/
https://reviews.llvm.org/D107669
hanbingwang added inline comments.
Comment at:
lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileSaver.cpp:87
+llvm::Expected
+TraceIntelPTSessionFileSaver::BuildProcessesSection(lldb::ProcessSP
_sp,
+TraceIntelPT
hanbingwang updated this revision to Diff 365883.
hanbingwang marked an inline comment as done.
hanbingwang added a comment.
*trace.h:
-rename SaveToDisk() to SaveLiveTraceToDisk()
*IntelPTDecoder.h, IntelPTDecoder.cpp:
-removed GetRawTrace()
*TraceIntelPT.h, TraceIntelPT.cpp:
-removed
wallace added inline comments.
Comment at:
lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileSaver.cpp:19
+#include "lldb/lldb-types.h"
+#include "llvm/Analysis/ModuleSummaryAnalysis.h"
+#include "llvm/Support/Error.h"
this doesn't seem relevant
wallace added inline comments.
Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:267-281
+llvm::Expected> PostMortemThreadDecoder::GetRawTrace() {
+ FileSpec trace_file = m_trace_thread->GetTraceFile();
+ ErrorOr> trace_or_error =
+
wallace added inline comments.
Comment at: lldb/include/lldb/Target/Trace.h:75
+ virtual llvm::Error SaveToDisk(FileSpec directory,
+ lldb::ProcessSP _sp) = 0;
+
clayborg wrote:
> This class will already have a process in
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/include/lldb/Target/Trace.h:75
+ virtual llvm::Error SaveToDisk(FileSpec directory,
+ lldb::ProcessSP
hanbingwang updated this revision to Diff 364893.
hanbingwang added a comment.
fix a typo. change a string "the trace of ..." from "the trace or ..."
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107669/new/
https://reviews.llvm.org/D107669
Files:
lldb/include/lldb/Target/Trace.h
14 matches
Mail list logo
