[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

wallace added inline comments. Comment at: lldb/test/API/commands/trace/TestTraceExport.py:68-69 + +if os.path.exists(ctf_test_file): +remove_file(ctf_test_file) +self.expect(f"thread trace export ctf --file {ctf_test_file}") you don't

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

jj10306 updated this revision to Diff 365341. jj10306 added a comment. - move documentation to plugin directory - remove unnecessary checks in tests and remove test that wasn't testing anything different than the others - nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107674/new/ h

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp:394-419 +/* +name: load address of the first instruction of the block and the name +of the

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

jj10306 updated this revision to Diff 365346. jj10306 added a comment. - fix comment style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107674/new/ https://reviews.llvm.org/D107674 Files: lldb/docs/htr.rst lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp lldb/source/Plugins

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

jj10306 updated this revision to Diff 365477. jj10306 added a comment. lint + comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107674/new/ https://reviews.llvm.org/D107674 Files: lldb/docs/htr.rst lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp lldb/source/Plugins/Tra

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef28c78350db: [tests] [trace] Add a more comprehensive test for `thread trace export ctf`… (authored by Walter Erquinigo ). Reposit