ldionne accepted this revision.
ldionne added a comment.
This LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
gAlfonso-bit added a comment.
Alright. Thank you!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
gAlfonso-bit updated this revision to Diff 365275.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
Files:
clang/CMakeLists.txt
clang/lib/Basic/CMakeLists.txt
compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake
compiler-rt/cmake
gAlfonso-bit added a comment.
So does that mean this is ready to land?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
gAlfonso-bit updated this revision to Diff 365507.
gAlfonso-bit added a comment.
Rebase
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
Files:
clang/CMakeLists.txt
clang/lib/Basic/CMakeLists.txt
compiler-rt/cmake/Modules/CompilerRTMockLL
gAlfonso-bit added a comment.
@ldionne is this ok? any other changes?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
gAlfonso-bit updated this revision to Diff 365802.
gAlfonso-bit added a comment.
Rebased
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
Files:
clang/CMakeLists.txt
clang/lib/Basic/CMakeLists.txt
compiler-rt/cmake/Modules/CompilerRTMockL
gAlfonso-bit updated this revision to Diff 366014.
gAlfonso-bit added a comment.
Rebased
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
Files:
clang/CMakeLists.txt
clang/lib/Basic/CMakeLists.txt
compiler-rt/cmake/Modules/CompilerRTMockL
gAlfonso-bit updated this revision to Diff 366497.
gAlfonso-bit added a comment.
Rebased to main
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
Files:
clang/CMakeLists.txt
clang/lib/Basic/CMakeLists.txt
compiler-rt/cmake/Modules/Compile
gAlfonso-bit added a comment.
@ldionne can we land this please?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
gAlfonso-bit updated this revision to Diff 366671.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
Files:
clang/CMakeLists.txt
clang/lib/Basic/CMakeLists.txt
compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake
compiler-rt/cmake
gAlfonso-bit added a comment.
I don't think there are any other outstanding issues. Are we good to accept and
merge? @ldionne
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing
gAlfonso-bit added a comment.
@ldionne update?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
Mordante added a comment.
Since @ldionne approved this patch it's good to land. If you don't have commit
access, can you provide "Your name" , then somebody can
commit the change for you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
_
gAlfonso-bit updated this revision to Diff 370957.
gAlfonso-bit added a comment.
Rebase to Main @ldionne
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
Files:
clang/CMakeLists.txt
clang/lib/Basic/CMakeLists.txt
compiler-rt/cmake/Modules
gAlfonso-bit added a comment.
@Mordante Alfonso Gregory gfunni...@gmail.com
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
gAlfonso-bit added a comment.
@ldionne can you please please merge
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa2c319fdc6b3: [LLVM][CMake][NFC] Resolve FIXME: Rename
LLVM_CMAKE_PATH to LLVM_CMAKE_DIR… (authored by gAlfonso-bit, committed by
Mordante).
Herald added a project: LLDB.
Herald added a reviewer: libunwin
gAlfonso-bit updated this revision to Diff 372770.
gAlfonso-bit added a comment.
Rebased to main
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107717/new/
https://reviews.llvm.org/D107717
Files:
clang/CMakeLists.txt
clang/lib/Basic/CMakeLists.txt
compiler-rt/cmake/Modules/Compile
19 matches
Mail list logo