[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21e2d7ce43c4: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize() (authored by mgorny). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny updated this revision to Diff 371618. mgorny marked 2 inline comments as done. mgorny added a comment. Use LLVM's `ubig*_t` types. Thanks for the suggestion, @labath! Also add the comment that `Stat()` is only a wrapper over open+fstat. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h:56-70 +struct GDBRemoteFStatData { + uint32_t gdb_st_dev; + uint32_t gdb_st_ino; + uint32_t gdb_st_mode; + uint32_t gdb_st_nlink; + uint32_t gdb_st_uid; + uint32_t

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny updated this revision to Diff 371300. mgorny added a comment. Fix lint warnings. Add a note about not-full-replacement as requested in D107811 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 Files:

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny added a comment. @jasonmolenda, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny updated this revision to Diff 365414. mgorny added a comment. Add a helper `Stat` method to take care of opening and closing the file. Add a cache variable for whether `vFile:size` is supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny updated this revision to Diff 365408. mgorny added a comment. Fix integer-type related warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny added a comment. This covers client side only, I'm going to work on the server side `vFile:stat` packet later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny created this revision. mgorny added reviewers: labath, krytarowski, jasonmolenda, emaste, JDevlieghere. mgorny requested review of this revision. Implement a fallback to getting the file size via vFile:stat packet when the remote server does not implement vFile:size. This makes it