[Lldb-commits] [PATCH] D108018: [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded

2021-08-12 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: krytarowski, emaste, labath, jasonmolenda, JDevlieghere. mgorny requested review of this revision. Fall back to QEnvironmentHexEncoded if QEnvironment is not supported. The latter packet is an LLDB extension, while the former is universally sup

[Lldb-commits] [PATCH] D108018: [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded

2021-09-07 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Comment at: lldb/test/API/tools/lldb-server/main.cpp:332 + const char *value = getenv(arg.c_str()); + printf("%s\n", value ? value : "__unset__"); } else

[Lldb-commits] [PATCH] D108018: [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded

2021-09-07 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/main.cpp:332 + const char *value = getenv(arg.c_str()); + printf("%s\n", value ? value : "__unset__"); } else { labath wrote: > Printing a quoted this in the case of a null p

[Lldb-commits] [PATCH] D108018: [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded

2021-09-07 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/test/API/tools/lldb-server/main.cpp:332 + const char *value = getenv(arg.c_str()); + printf("%s\n", value ? value : "__unset__"); } else { mgorny wrote: > labath wrote: > > Printing a quoted this in th

[Lldb-commits] [PATCH] D108018: [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded

2021-09-10 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fade9542200: [lldb] [gdb-remote] Support QEnvironment fallback to hex-encoded (authored by mgorny). Herald added a project: LLDB. Repository: rG