[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

mgorny abandoned this revision. mgorny added a comment. Replaced by D110027 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108768/new/ https://reviews.llvm.org/D108768 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

omjavaid added a comment. This is complicated mainly because we are trying to merge two different register numbering scheme. On LLDB (host) side we try to construct register number from parsing register xml assigning register numbers in the increasing order. But we also have target supplied reg

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

labath added a reviewer: omjavaid. labath added a comment. I'm not sure if this is correct, or if I want it to be correct. I think that a lot of the confusion comes from the fact that this structure is used both in lldb-server and lldb, and I'm not sure that the fields have the same meaning in

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

mgorny updated this revision to Diff 369048. mgorny added a comment. Also updated the comments in `struct RegisterInfo` to indicate what kind of numbers go in these arrays. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108768/new/ https://reviews.llvm.org/D108768 Files: lldb/include

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

mgorny updated this revision to Diff 369042. mgorny retitled this revision from "[lldb] [DynamicRegisterInfo] Fix mistaken reg type when calculating offsets" to "[lldb] DynamicRegisterInfo: fix wrong regnos in Dump()". mgorny edited the summary of this revision. mgorny added a comment. So I've g