[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369376. xgupta added a comment. restore a blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/resources/test.rst lldb/docs/testsuite/best-p

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369375. xgupta added a comment. remove best-practice.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst lldb/docs/resources/test.rst

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. In D108812#2971657 , @JDevlieghere wrote: > I'm not convinced this warrants a whole new section. Especially since this is > focussed on lldb developers rather than end users. Could we move this under > the resources/test page?

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369374. xgupta added a comment. Move testsuite/best-practice comtain to resources/test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I'm not convinced this warrants a whole new section. Especially since this is focussed on lldb developers rather than end users. Could we move this under the resources/te

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:53 + +Cleanup after yourself +-- teemperor wrote: > This section here seems very outdated, can we just delete it? sure Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369328. xgupta added a comment. Remove an outdated paragraph Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/index.rst lldb/docs/testsuite/best-pr

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

teemperor added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:53 + +Cleanup after yourself +-- This section here seems very outdated, can we just delete it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. I can confirm that it renders correctly, please commit it at your convenience. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369254. xgupta added a comment. Herald added a subscriber: arphaman. add best-practices entry to index.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lld

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks for doing this. Presuming you've verified that it renders correctly, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ htt

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:19 + +:: + mgorny wrote: > …seems to be a common pattern in LLVM. > > (and similarly for other instances of `::`) Thanks, I missed that. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369252. xgupta added a comment. Fix .. code-block:: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/testsuite/best-practices.rst lldb/docs/testsui

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: lldb/docs/testsuite/best-practices.rst:19 + +:: + …seems to be a common pattern in LLVM. (and similarly for other instances of `::

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. I later realize that we already have https://lldb.llvm.org/resources/test.html which contains some similar instructions to write testcases. So not sure we want to have this document. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta created this revision. xgupta updated this revision to Diff 369103. xgupta added a comment. xgupta published this revision for review. xgupta added reviewers: teemperor, mgorny, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add ToC This file contain