[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext_x86.cpp:37-54 +static std::array partial_gpr_regs = {{ +{"rax", {{"eax"}, {"ax"}, {"ah"}, {"al"}}}, +{"rbx", {{"ebx"}, {"bx"}, {"bh"}, {"bl"}}}, +{"rcx", {{"ecx"

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny added a comment. @labath, could you look at my inline comments before I start moving stuff? ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

labath added a comment. In D108831#2999227 , @mgorny wrote: > Another question: should we aim to remove the 'redundant afterwards' bits > from lldb-server, and fill them in from client side entirely? I don't think > our process plugins really need knowl

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny added a comment. Another question: should we aim to remove the 'redundant afterwards' bits from lldb-server, and fill them in from client side entirely? I don't think our process plugins really need knowledge of EAX etc., and it would reduce the duplication a fair bit. Also I'm not sure

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

labath added a comment. This is an interesting problem. I don't yet know how, but as I alluded to in the other patch, my instinct would be to find a way to put this into the ABI class, in order to keep the "fill in bits not provided by debug server" code in a single place. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 372261. mgorny added a comment. Rename the file to `_x86.cpp` to future-proof it. Replace`assert()s` with explicit skipping, we don't really want to crash on unexpected data in `target.xml`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 370786. mgorny added a comment. Restore the `sp` test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt lldb/source/Plugins/Process/gdb-remote

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 370754. mgorny added a comment. Fix filename in heading. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt lldb/source/Plugins/Process/gdb-remo

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 369422. mgorny added a comment. Add tests for reading back (should verify invalidation). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt lldb

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 369421. mgorny added a comment. Add writing tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt lldb/source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 369130. mgorny added a comment. Remove unnecessary include. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt lldb/source/Plugins/Process/gdb-r

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny created this revision. mgorny added reviewers: krytarowski, jasonmolenda, JDevlieghere, labath, emaste. Herald added a subscriber: pengfei. mgorny requested review of this revision. Add a pre- and post-finalize hooks to GDBRemoteRegisterContext that add missing pseudo-register on x86_64. T