[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

2021-09-08 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd2189b5c4b01: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

2021-09-08 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a reviewer: teemperor. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Asking for review to double check. Nothing in lldb upstream calls this and I think that's because we switched to a style where we ask to attach then have a callback that will tell u

[Lldb-commits] [PATCH] D109427: [lldb] Remove unused GDBRemoteCommunicationClient::SendAttach function

2021-09-08 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109427 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicati