[Lldb-commits] [PATCH] D109695: [lldb] [Process/gdb-remote] Add x31 AArch64 register for gdbserver

2021-09-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D109695#2999221 , @mgorny wrote: > In D109695#2999171 , @labath wrote: > >> Let's take a step back. First, I'd like to understand why are you adding a >> whole new register, instead of

[Lldb-commits] [PATCH] D109695: [lldb] [Process/gdb-remote] Add x31 AArch64 register for gdbserver

2021-09-14 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. In D109695#2999171 , @labath wrote: > Let's take a step back. First, I'd like to understand why are you adding a > whole new register, instead of just an alias (alt_name) for an existing > register. Well, I was thinking 'what if

[Lldb-commits] [PATCH] D109695: [lldb] [Process/gdb-remote] Add x31 AArch64 register for gdbserver

2021-09-14 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Let's take a step back. First, I'd like to understand why are you adding a whole new register, instead of just an alias (alt_name) for an existing register. And second, have you cons

[Lldb-commits] [PATCH] D109695: [lldb] [Process/gdb-remote] Add x31 AArch64 register for gdbserver

2021-09-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added subscribers: omjavaid, kristof.beyls. mgorny requested review of this revision. Create an x31 register that is aliased to sp if the latter is present and the former is not. This is needed to bring gdbs