[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

2021-09-17 Thread Markus Böck via Phabricator via lldb-commits
zero9178 created this revision. zero9178 added reviewers: phosek, hans, MaskRay, compnerd. Herald added subscribers: arphaman, mgorny. zero9178 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Linking against the LibXml2::L

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

2021-09-17 Thread Arthur O'Dwyer via Phabricator via lldb-commits
Quuxplusone added a comment. Herald added a subscriber: JDevlieghere. Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have been unable to build clang because, even with a totally-empty-and-brand-new build directory, CMake says: CMake Error in lib/WindowsManifest/CMakeL

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

2021-09-17 Thread Markus Böck via Phabricator via lldb-commits
zero9178 added a comment. In D109975#3006580 , @Quuxplusone wrote: > Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have > been unable to build clang because, even with a totally-empty-and-brand-new > build directory, CMake say

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

2021-09-17 Thread Arthur O'Dwyer via Phabricator via lldb-commits
Quuxplusone added a comment. I was inspired to dig down and find the `LLVM_ENABLE_LIBXML2` option (which is on by default) and turn it off, so now I can build clang with the following commands: cmake -G Ninja -DLLVM_ENABLE_LIBXML2=0 -DDEFAULT_SYSROOT="$(xcrun --show-sdk-path)" -DLLVM_ENABLE_

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

2021-09-23 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109975/new/ https://reviews.llvm.org/D109975 _

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

2021-09-25 Thread Markus Böck via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0b61f43b6096: [CMake] Consistently use the LibXml2::LibXml2 target instead of… (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109975/n