[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

mgorny marked 3 inline comments as done. mgorny added a comment. Filed D110535 for suggested changes. Comment at: llvm/include/llvm/ADT/StringExtras.h:527-529 +std::pair Res = Next.split(Separator); +Current = Res.first; +Next = Re

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

labath added a comment. I like it as well :) Comment at: llvm/include/llvm/ADT/StringExtras.h:519 + bool operator==(const SplittingIterator &R) const { +return Current == R.Current && Next == R.Next && Separator == R.Separator; + } This compares the conte

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4b71e3479bf: [llvm] [ADT] Add a range/iterator-based Split() (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based Split()

mgorny updated this revision to Diff 375162. mgorny retitled this revision from "[llvm] [ADT] Add a range/iterator-based split()" to "[llvm] [ADT] Add a range/iterator-based Split()". mgorny edited the summary of this revision. mgorny added a comment. Attempt to fix linter issues. CHANGES SINCE

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based split()

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. This is really nice! Please fix the clang-tidy casing issues, but otherwise LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110496/new/ https://reviews.llvm.org/D110496 _

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based split()

mgorny updated this revision to Diff 375126. mgorny added a comment. Convert more LLDB gdb-remote calls. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110496/new/ https://reviews.llvm.org/D110496 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp lldb/so

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based split()

mgorny added inline comments. Comment at: llvm/lib/IR/DataLayout.cpp:219 /// Checked version of split, to ensure mandatory subparts. -static Error split(StringRef Str, char Separator, - std::pair &Split) { I needed to rename this due to collisi

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based split()

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, JDevlieghere, emaste, lattner, rriddle. Herald added subscribers: dexonsmith, hiraditya. mgorny requested review of this revision. Herald added a project: LLVM. Add a llvm::split() implementation that can be use