This revision was automatically updated to reflect the committed changes.
Closed by commit rG993ada05f5a0: [lldb] [unittests] Fix building the FreeBSD
arm64 Register Context test (authored by andrew, committed by emaste).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
andrew added a comment.
Yes, I found it by trying to build the tests on FreeBSD/arm64
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110545/new/
https://reviews.llvm.org/D110545
___
lldb-commits mailing l
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
LGTM now, thanks. I don't have an arm64 cross env handy at the time, so I'm
assuming you've tested it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
andrew updated this revision to Diff 375293.
andrew added a comment.
Set opt_regsets to eRegsetMaskDefault
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110545/new/
https://reviews.llvm.org/D110545
Files:
lldb/unittests/Process/Utility/RegisterC
mgorny added inline comments.
Comment at: lldb/unittests/Process/Utility/RegisterContextFreeBSDTest.cpp:328
TEST(RegisterContextFreeBSDTest, arm64) {
+ Flags opt_regsets;
ArchSpec arch{"aarch64-unknown-freebsd"};
Maybe set it to `eRegsetMaskDefault` explicit
andrew created this revision.
Herald added subscribers: omjavaid, kristof.beyls, emaste.
andrew requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D110545
Files:
lldb/unittests
