[Lldb-commits] [PATCH] D110553: [lldb] Remove non-stop mode code

2021-09-28 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG156cb4cc64be: [lldb] Remove non-stop mode code (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110553/new/ https://reviews.llvm.org/D110

[Lldb-commits] [PATCH] D110553: [lldb] Remove non-stop mode code

2021-09-27 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski accepted this revision. krytarowski added a comment. NetBSD and FreeBSD do not support non-stop in the kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110553/new/ https://reviews.llvm.org/D110553 _

[Lldb-commits] [PATCH] D110553: [lldb] Remove non-stop mode code

2021-09-27 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I don't think this patch added all that much value, and pretty much only worked if the non-stop threads never stopped... I think we'd have to start deeper in lldb to if we really want to su

[Lldb-commits] [PATCH] D110553: [lldb] Remove non-stop mode code

2021-09-27 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: jingham, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. We added some support for this mode back in 2015, but the feature was never productionized. It is completely untested, and there are known major stru