[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb0e687faeb: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

labath added a comment. In D111314#3050392 , @mgorny wrote: > In D111314#3050383 , @labath wrote: > >> At one point these didn't use to be shared pointers so we couldn't copy them >> like this, though I am still

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

mgorny added a comment. In D111314#3050383 , @labath wrote: > At one point these didn't use to be shared pointers so we couldn't copy them > like this, though I am still unclear as to why we need two of them in the > first place. Actually, I've asked y

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. At one point these didn't use to be shared pointers so we couldn't copy them like this, though I am still unclear as to why we need two of them in the first place. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Replace separate read and write NativeFile instances with a single instance shared for reading and writing. There is no clear indication why two instances were u