[Lldb-commits] [PATCH] D111402: [lldb] [test] Use secondary pty end for testing Terminal

2021-10-08 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG71fd5a735ec2: [lldb] [test] Use secondary pty end for testing Terminal (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D111402: [lldb] [test] Use secondary pty end for testing Terminal

2021-10-08 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. If Green Dragon was still with us this would make it happy (and green), so LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111402/new/ https://reviews.llvm.org/D111402

[Lldb-commits] [PATCH] D111402: [lldb] [test] Use secondary pty end for testing Terminal

2021-10-08 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: teemperor, labath, krytarowski, emaste. mgorny requested review of this revision. Open and use the secondary end of a pty for testing Terminal properties in order to fix the tests on Darwin. While at it, streamline getting the fd and Terminal