[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8bac18be0e45: [lldb] Reduce code duplication around inferior building (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111989/new/

[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

2021-10-19 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111989/new/ https://reviews.llvm.org/D111989

[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

2021-10-18 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 380372. labath added a comment. Adjust for TestStandardUnwind removal (the patch fixes it sufficiently to make it litter the source tree with build artifacts). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

2021-10-18 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: teemperor, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. We had two sets of build methods, whose bodies were largely identical. This makes any kind of modification in their vicinity repetitive and