[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG738621d047f2: [lldb/bindings] Change ScriptedThread initializer parameters (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112046/new/ http

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112046/new/ https://reviews.llvm.org/D112046 __

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

mib added a comment. In D112046#3081556 , @mib wrote: > In D112046#3081547 , @JDevlieghere > wrote: > >> Given that there's a 1:1 mapping between the target and the process, why did >> you change the interface a

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

mib added a comment. In D112046#3081547 , @JDevlieghere wrote: > Given that there's a 1:1 mapping between the target and the process, why did > you change the interface as opposed to say extracting the process from the > target? A process is guarantee

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

JDevlieghere added a comment. Given that there's a 1:1 mapping between the target and the process, why did you change the interface as opposed to say extracting the process from the target? Comment at: lldb/examples/python/scripted_process/my_scripted_process.py:137

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

mib updated this revision to Diff 380818. mib added a comment. Update after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112046/new/ https://reviews.llvm.org/D112046 Files: lldb/bindings/python/python-wrapper.swig lldb/examples/python

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the `ScriptedThread` initializer in couple of ways: - It replaces the `SBTarget` parameter by a `SBProcess`