[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG976867b513ab: [lldb/test] Update TestScriptedProcess to use skinny corefiles (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

JDevlieghere added a comment. Some of the formatting in the Python tests seems a little off (can you run it through something like yapf ?). Other than that this LGTM with the inline comments addressed. Comment at:

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 386176. mib added a comment. Move `stack_core_scripted_process.py` from `examples` to `test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files:

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1 +import os,struct,signal + mib wrote: > JDevlieghere wrote: > > This should live next to the test. I don't see a point of shipping this to >

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 386021. mib marked 2 inline comments as done. mib added a comment. Address @JDevlieghere comments and skip test for non x86_64 archs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1 +import os,struct,signal + JDevlieghere wrote: > This should live next to the test. I don't see a point of

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1 +import os,struct,signal + This should live next to the test. I don't see a point of shipping this to users. Comment at:

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 381020. mib added a comment. Add `self` argument to scripted_process base class methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files:

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 380825. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files: lldb/examples/python/scripted_process/main.stack-dump lldb/examples/python/scripted_process/my_scripted_process.py

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 380819. mib added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files: lldb/examples/python/scripted_process/main.stack-dump

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 380664. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files: lldb/examples/python/scripted_process/main.stack-dump

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the ScriptedProcess test to use a stack-only skinny corefile as a backing store. The corefile is saved as a