This revision was automatically updated to reflect the committed changes.
Closed by commit rG50b40b051890: [lldb] Improve error reporting in `lang objc
tagged-pointer info` (authored by JDevlieghere).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Excellent, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112945/new/
https://reviews.llvm.org/D112945
___
lldb-commits mailing
JDevlieghere updated this revision to Diff 384193.
JDevlieghere added a comment.
Address code review feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112945/new/
https://reviews.llvm.org/D112945
Files:
aprantl added inline comments.
Comment at: lldb/test/Shell/ObjC/tagged_pointer_info.test:3
+
+RUN: %clang_host -g -framework Foundation -o %t.out %S/Inputs/test.m
+
personal opinion without through reasoning behind it: This feels more like an
API test to me.
aprantl added a comment.
This is great, thanks! (one question inline)
Comment at:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:1008
}
- result.SetStatus(lldb::eReturnStatusSuccessFinishResult);
- return true;
+ success
JDevlieghere updated this revision to Diff 383851.
JDevlieghere added a comment.
Add test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112945/new/
https://reviews.llvm.org/D112945
Files:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
JDevlieghere created this revision.
JDevlieghere added a reviewer: aprantl.
JDevlieghere requested review of this revision.
Improve error handling for the `lang objc tagged-pointer info`. Rather than
failing silently, report an error if we couldn't convert an argument to an
address or resolve
