[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna added a comment. @stella.stamenova fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna added a comment. In D113047#3106732 , @stella.stamenova wrote: > The Windows buildbot is still broken after this change: > > https://lab.llvm.org/buildbot/#/builders/83/builds/11630 sorry again :/ I will fix. It's takaing me a

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

stella.stamenova added a comment. The Windows buildbot is still broken after this change: https://lab.llvm.org/buildbot/#/builders/83/builds/11630 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

stella.stamenova added inline comments. Comment at: lldb/test/Shell/Settings/TestEchoCommands.test:4 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out -# RUN: %lldb -x -b

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f01f78593d6: [lldb] update TestEchoCommands (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham, stella.stamenova. lawrence_danna requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Followup to https://reviews.llvm.org/D112988