[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

labath added a comment. In D113789#3133205 , @clayborg wrote: > In D113789#3130741 , @labath wrote: > >> Maybe it's good for starting a discussion, but I am surprised that we would >> need to cache symtab informa

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg added a comment. Some perf numbers that involve loading a large iOS Application and all of its shared libraries without caching first and then with caching are found below. The "lldb-perf.py" command will start a timer, run any LLDB commands and then stop the timer and print out. Befor

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg added a comment. Thinking about this a bit more after Pavel's comment on if performance was improved due to mangling: we don't currently get any perf improvement from mangling/demangling. We might be able to get better performance out of this as well if we _do_ cache the "mangled/deman

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg added a comment. In D113789#3130741 , @labath wrote: > Maybe it's good for starting a discussion, but I am surprised that we would > need to cache symtab information. This is a fairly simple format that needs > to be read at application runtime

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

labath added a comment. Maybe it's good for starting a discussion, but I am surprised that we would need to cache symtab information. This is a fairly simple format that needs to be read at application runtime as well, so I am surprised that reading it from the cache is substantially faster tha

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. There are two things that could be added. One is already mentioned in the comments, which is logging error messages in a way that we can track bugs in an automated fashion, as righ

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg marked 4 inline comments as done. clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:713 + /// is unknown or can't be determined. + lldb::addr_t m_length; + /// The data for this object file so things can be parsed lazily. --

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg updated this revision to Diff 386972. clayborg added a comment. Added more comments to the encoding functions to detail how things are encoded. Fixed error typos. Added version to symbol table cache file so we can improve the format as time goes on and avoid loading out of data caches.

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

bulbazord added a comment. This patch effectively introduces a file format to cache lldb internal state. While the tests and the code do give some information for what it looks like, some documentation about this format would be nice. I like this idea a lot! My comments were kind of surface lev

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg created this revision. clayborg added reviewers: jingham, labath, JDevlieghere, wallace, aadsm. Herald added subscribers: mgorny, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. Added the ability to cache t