[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added a comment. > Do you have an repro case that will show this issue? I would need to debug it. @clayborg sorry for the late reply. The repro happened to me while debugging some Swift: func main() { let digits = /\d+/ let match = "abc123".firstMatch(of: digits)

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg added a comment. In D114288#3781084 , @kastiglione wrote: > @clayborg friendly ping Do you have an repro case that will show this issue? I would need to debug it. The main issue is ObjectFileJIT::ParseSymtab() is doing global lookups when it

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added a comment. Herald added a reviewer: ributzka. @clayborg friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.org/D114288 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added inline comments. Herald added subscribers: pmatos, asb. Herald added a project: All. Comment at: lldb/source/Symbol/ObjectFile.cpp:739 +// are protected by a mutex in the Symtab object itself. +llvm::call_once(*m_symtab_once_up, [&]() { + ElapsedTi

Re: [Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

Thanks for doing that! I was able to successfully run the test on linux, and then I added extra context to the stop. It seems that the two breakpoints are set correctly, but the second breakpoint is not hit and the program exits. So all is good from the symbol table changes as far as I have been

Re: [Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

On Fri, 3 Dec 2021 at 04:50, Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > In D114288#3165212 , @clayborg > wrote: > > > In D114288#3163808 , > @omjavaid wrote: > >

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg added a comment. In D114288#3165212 , @clayborg wrote: > In D114288#3163808 , @omjavaid > wrote: > >> Hi @clayborg >> This breaks LLDB Arm/Linux buildbot. >> https://lab.llvm.org/buildbot/#/builders/17

Re: [Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

On Thu, 2 Dec 2021 at 01:37, Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > In D114288#3163808 , @omjavaid > wrote: > > > Hi @clayborg > > This breaks LLDB Arm/Linux buildbot. > https://lab.llvm.org/buildbot

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg added a comment. In D114288#3163808 , @omjavaid wrote: > Hi @clayborg > This breaks LLDB Arm/Linux buildbot. > https://lab.llvm.org/buildbot/#/builders/17/builds/14035 I will check this out on linux. Any reason why I did not get a message to m

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

omjavaid added a comment. Hi @clayborg This breaks LLDB Arm/Linux buildbot. https://lab.llvm.org/buildbot/#/builders/17/builds/14035 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.org/D114288 _

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e6df41f655e: [NFC] Refactor symbol table parsing. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg updated this revision to Diff 390444. clayborg added a comment. Let the call_once protect the ObjectFile::m_symtab_up as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.org/D114288 Files: lldb/i

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

labath added a comment. In D114288#3152709 , @clayborg wrote: > Do all .dwo files claim the main executable that references them is their > owning module? The short answer is "yes". The reason for that is that the dwo files do not constitute a module i

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg added a comment. In D114288#3149188 , @labath wrote: > I don't believe this solution is correct. > > How did this work before? Is it because `ObjectFileELF::GetSymtab` contained > the same (incorrect) unique_ptr pattern? It did, but because eac

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

labath added a comment. I don't believe this solution is correct. How did this work before? Is it because `ObjectFileELF::GetSymtab` contained the same (incorrect) unique_ptr pattern? How about we just prime the symtab (or whatever is needed) before we start the thread pool indexing? ==

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg created this revision. clayborg added reviewers: labath, jingham, JDevlieghere. Herald added subscribers: sbc100, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay, aheejin. Herald added a project: LLDB. Symbol table parsing has evolved ov