[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9b8f422e711: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code (authored by ljmf00). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D114668?vs=3918

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added a comment. Sorry for leaving this hanging for a long time. Feel free to leave feedback if I'm missing something, in the meantime. I'll try to push the other patches too. I ran the test suite again and didn't break anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:1 +#include "DWARFASTParser.h" +#include "DWARFAttribute.h" bulbazord wrote: > This file will need a license header. Yes, my bad. Thanks for noticing it. =

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

shafik added a subscriber: clayborg. shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:77 + default: + case DW_AT_abstract_origin: + case DW_AT_accessibility: ljmf00 wrote: > bulbazord wro

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:77 + default: + case DW_AT_abstract_origin: + case DW_AT_accessibility: shafik wrote: > ljmf00 wrote: > > bulbazord wrote: > > > ljmf00

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 updated this revision to Diff 391856. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114668/new/ https://reviews.llvm.org/D114668 Files: lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:1 +#include "DWARFASTParser.h" +#include "DWARFAttribute.h" ljmf00 wrote: > bulbazord wrote: > > This file will need a license header. > Yes, my bad. Thanks for noti

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 updated this revision to Diff 391867. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114668/new/ https://reviews.llvm.org/D114668 Files: lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added a comment. In D114668#3159640 , @bulbazord wrote: > I think breaking it out of the Clang-specific class makes sense if we want > LLDB to be more language-agnostic. Do you have an idea of what bits of > `DWARFASTParserClang` can be moved out

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added a comment. Ping @shafik @bulbazord . Can you re-review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114668/new/ https://reviews.llvm.org/D114668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c