ljmf00 created this revision.
ljmf00 added a project: LLDB.
Herald added subscribers: JDevlieghere, mgorny.
Herald added a reviewer: shafik.
ljmf00 requested review of this revision.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D114668
F
ljmf00 added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:77
+ default:
+ case DW_AT_abstract_origin:
+ case DW_AT_accessibility:
Why we are including just these specific attributes? Maybe we shou
bulbazord added a comment.
I think breaking it out of the Clang-specific class makes sense if we want LLDB
to be more language-agnostic. Do you have an idea of what bits of
`DWARFASTParserClang` can be moved out other than `ParseChildArrayInfo` and
`GetAccessTypeFromDWARF` (from the patch on to
