[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

shafik added a comment. I would also like to know where this duplicate insertion is happening. Can you walk us through the steps that lead to the duplicate entries? thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115308/new/ https://revie

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

zequanwu added a comment. In D115308#3184564 , @shafik wrote: > I would also like to know where this duplicate insertion is happening. Can > you walk us through the steps that lead to the duplicate entries? thank you! Firstly, I found that `SymbolFileDW

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

labath added a comment. I don't know whether the types should be uniqued at this level (obviously, they should be uniqued somewhere), but these are the thoughts that spring to mind: - if this is a problem for lldb-test, then it would be preferable to come up with a solution that does not negati

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

zequanwu updated this revision to Diff 395543. zequanwu added a comment. Revert back to first diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115308/new/ https://reviews.llvm.org/D115308 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPa

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

zequanwu added a comment. In D115308#3189261 , @labath wrote: > I don't know whether the types should be uniqued at this level (obviously, > they should be uniqued somewhere), but these are the thoughts that spring to > mind: > > - if this is a problem