[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

2021-12-20 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7406d236d873: [lldb/python] Fix (some) dangling pointers in our glue code (authored by labath). Changed prior to commit: https://reviews.llvm.org/D115925?vs=395072&id=395389#toc Repository: rG LLVM G

[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

2021-12-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Thanks. In case anyone's wondering, the reason for that stray command is because I originally wanted to test this via `use_debugger` command. However, that turned out to not work because the SBDebugger object for the `use_debugger`s own argument was created at the exact

[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

2021-12-17 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Thanks for fixing this! LGTM beside a small nit. Comment at: lldb/test/API/commands/command/script/TestCommandScript.py:172 +self.runCmd("command script add -f persistence.

[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

2021-12-17 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, mib. labath requested review of this revision. Herald added a project: LLDB. This starts to fix the other half of the lifetime problems in this code - dangling references. SB objects created on the stack will go away when the fu