Re: [Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

Thanks Pavel, that fix is good. > On Dec 29, 2021, at 1:05 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > The problem was that (without accelerator tables) we would always have more > than one cache file for a given module. I have now adjusted the test (daed479 > <

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

labath added a comment. The problem was that (without accelerator tables) we would always have more than one cache file for a given module. I have now adjusted the test (daed479 ) to check for the presence of one _symtab_ inde

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

omjavaid added a comment. @clayborg This breaks LLDB Linux buildbots: https://lab.llvm.org/buildbot/#/builders/17/builds/15166 https://lab.llvm.org/buildbot/#/builders/96/builds/16114 https://lab.llvm.org/buildbot/#/builders/68/builds/23796 Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2154b195153: Cache the manual DWARF index out to the LLDB cache directory when the LLDB… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115951/new/ https://reviews.llvm.org/D115951 _

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

clayborg updated this revision to Diff 395441. clayborg added a comment. Remove commented out code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115951/new/ https://reviews.llvm.org/D115951 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/in

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

clayborg updated this revision to Diff 395440. clayborg added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115951/new/ https://reviews.llvm.org/D115951 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/incl

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:59 +return m_dwo_num_valid == rhs.m_dwo_num_valid && + m_dwo_num == rhs.m_dwo_num && m_section == rhs.m_section && + m_die_offset == rhs.m_die_offset;

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/Symtab.h:279 m_mutex; // Provide thread safety for this symbol table - bool m_file_addr_to_index_computed : 1, m_name_indexes_computed : 1; + bool m_file_addr_to_index_computed : 1, m_name_indexes_compu

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

wallace added inline comments. Comment at: lldb/include/lldb/Symbol/Symtab.h:279 m_mutex; // Provide thread safety for this symbol table - bool m_file_addr_to_index_computed : 1, m_name_indexes_computed : 1; + bool m_file_addr_to_index_computed : 1, m_name_indexes_comput

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

clayborg created this revision. clayborg added reviewers: labath, wallace, aadsm, jingham, JDevlieghere. Herald added subscribers: arphaman, mgorny. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a proje