[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-06 Thread James Henderson via Phabricator via lldb-commits
jhenderson accepted this revision. jhenderson added a comment. LGTM, from my point of view. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-06 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu added a comment. It looks like @asl isn't here and many experienced guys accepted this. So I think it might should be good to commit this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 _

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-06 Thread Chuanqi Xu via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbce75e352be: Update Bug report URL to Github Issues (authored by

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-06 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu updated this revision to Diff 397763. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst clang/www/c_status

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-05 Thread James Henderson via Phabricator via lldb-commits
jhenderson added inline comments. Comment at: llvm/docs/CommandGuide/llvm-install-name-tool.rst:79 -To report bugs, please visit . +To report bugs, please visit . I believe llvm-install-nam

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-05 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu added a comment. @asl hi, do you feel good with this revision? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Arthur O'Dwyer via Phabricator via lldb-commits
Quuxplusone added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_ -

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_ -

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread ksyx via Phabricator via lldb-commits
ksyx added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added inline comments. Comment at: lld/docs/_templates/indexsidebar.html:3-4 lld bugs should be reported at the - LLVM https://bugs.llvm.org/";>Bugzilla. + LLVM https://github.com/llvm/llvm-project/issues/";>Issues. ChuanqiXu wrote: > MaskRay wrote:

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu updated this revision to Diff 396737. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Drop the change in lld. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clan

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu added inline comments. Comment at: llvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn:10 output = "$target_gen_dir/config.h" values = [ +"BUG_REPORT_URL=https://github.com/llvm/llvm-project/issues/";, xbolva00 wrote: > This url should

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:539 -To report bugs, please visit . +To report bugs, please visit . -

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 added inline comments. Comment at: llvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn:10 output = "$target_gen_dir/config.h" values = [ +"BUG_REPORT_URL=https://github.com/llvm/llvm-project/issues/";, This url should redirect to github

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added inline comments. Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:539 -To report bugs, please visit . +To report bugs, please visit . https://github.com/llvm/llvm-project/l

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu marked 14 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/www/c_status.html:75-76 -The https://bugs.llvm.org/";>LLVM bug tracker contains a -Clang C component that tracks known bugs with Clang's language +The https://github.com/llvm/llvm-pr

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu updated this revision to Diff 396627. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu updated this revision to Diff 396589. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_ -

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added a subscriber: jhenderson. MaskRay added a comment. @jhenderson Comment at: libunwind/docs/index.rst:101 * `LLVM Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `cfe-co

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Arthur O'Dwyer via Phabricator via lldb-commits
Quuxplusone accepted this revision. Quuxplusone added a comment. Tweaked English wording throughout. LGTM with all these modifications made. Orthogonally, it does occur to me that one might save a //lot// of this churn (and also the next time the bug tracker moves, e.g. if we go from GitHub to

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Louis Dionne via Phabricator via lldb-commits
ldionne accepted this revision as: libc++, libunwind. ldionne added a comment. Libc++ and libunwind changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu marked 7 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/www/c_status.html:76 +The https://bugs.llvm.org/";>LLVM bug tracker and +https://github.com/llvm/llvm-project/issues/";>LLVM Issues contain +a Clang C component that tracks known bugs

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu updated this revision to Diff 396498. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst clang/www/c_status

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Anton Korobeynikov via Phabricator via lldb-commits
asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Will you please check the comments and reword everything using proper terminology and new things we're having on GitHub? Comment at: clang/www/c_status.html:76 +The http

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu updated this revision to Diff 396509. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst clang/www/c_status

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added inline comments. Herald added a subscriber: JDevlieghere. Comment at: llvm/docs/DeveloperPolicy.rst:64 +.. FIXME: Edit for LLVM Issues in Github. + You can drop this and let others fix this paragraph. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, asl. Herald added subscribers: libcxx-commits, ormris, arphaman, mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: MaskRay. Herald added a project: libunwind. Herald added a reviewer: libunwin

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

2022-01-04 Thread Anton Korobeynikov via Phabricator via lldb-commits
asl requested changes to this revision. asl added a subscriber: tstellar. asl added a comment. This revision now requires changes to proceed. Thanks for doing this! I added few notes on the way. Comment at: clang/www/c_status.html:76 +The https://bugs.llvm.org/";>LLVM bug track