[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3bfd595a548: [lldb] Compute fully qualified command names in FindCommandsForApropos (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D116491?vs=397681&id=398034#toc Reposit

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D116491 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione updated this revision to Diff 397681. kastiglione added a comment. explicit std::string type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D116491 Files: lldb/include/lldb/Interpreter/CommandInter

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto &subcommand_name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +commands_found.AppendString(std:

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. I liked the small cleanups in the code as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto &subcommand_name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +commands_found.AppendString(std

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto &subcommand_name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +commands_found.AppendString(std:

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto &subcommand_name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +commands_found.AppendString(std

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione updated this revision to Diff 396955. kastiglione added a comment. Use std::move Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D116491 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h l

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos (NFC)

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl, augusto2112. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes incomplete command names in `apropos` results. The full command names given by