JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, teemperor, labath.
JDevlieghere requested review of this revision.
Until the introduction of the C++ REPL, there was always a single REPL
language. The code relied on this assumption through
`repl_languages.GetSingularLan
JDevlieghere added a comment.
No test because this is NFC upstream where there's only one supported REPL
language. This is tested downstream in the Swift fork.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116697/new/
https://reviews.llvm.org/D116697
__
aprantl added inline comments.
Comment at: lldb/source/Core/Debugger.cpp:1777
if (auto single_lang = repl_languages.GetSingularLanguage()) {
language = *single_lang;
As you said in the description, this is effectively dead code. Is this to be
remov
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/source/Core/Debugger.cpp:1777
if (auto single_lang = repl_languages.GetSingularLanguage()) {
language = *single_lang;
aprantl wrote:
> As you said in
This revision was automatically updated to reflect the committed changes.
JDevlieghere marked 2 inline comments as done.
Closed by commit rG46a28a954e5e: [lldb] Create a property to store the REPL
language (authored by JDevlieghere).
Herald added a project: LLDB.
Repository:
rG LLVM Github Mono
