[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

JDevlieghere commandeered this revision. JDevlieghere edited reviewers, added: aprantl; removed: JDevlieghere. JDevlieghere added a comment. I can do this after the rename. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/ https://reviews.llvm.org/D117632

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

aprantl added a comment. > I'm a little confused about what you want to achieve as well. With signposts you get a flamegraph of all nested signposted functions, which is really intuitive to look at. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117632/new/

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

aprantl abandoned this revision. aprantl added a comment. In D117632#3255158 , @JDevlieghere wrote: > Do you actually care about the timers or is this really about getting these > methods instrumented with signposts on our platform? If it's the latter,

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

JDevlieghere added a comment. Do you actually care about the timers or is this really about getting these methods instrumented with signposts on our platform? If it's the latter, I think it would make more sense to put that call in the `LLDB_RECORD_*` macros (which I'm planning to rename

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

labath added a comment. In D117632#3253445 , @jingham wrote: > I was about to say this shouldn't matter, since most people don't run with > timers enabled and the timers should be no-ops when timing is off. But > LLDB_SCOPED_TIMER seems to do a bunch

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

jingham added a comment. I was about to say this shouldn't matter, since most people don't run with timers enabled and the timers should be no-ops when timing is off. But LLDB_SCOPED_TIMER seems to do a bunch of work even when the timers are disabled. The work includes "look up the Category