[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

2022-02-09 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG73a961b9cca1: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

2022-02-09 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117676/new/ https://reviews.llvm.org/D117676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

2022-01-20 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. In D117676#3254662 , @labath wrote: > FWIW, I consider the build.py script a failed experiment. The idea itself was > not completely bad, but the lack of buy-in from sufficient amount of > developers meant that it never really

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

2022-01-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. To put it in a more constructive light, what I was trying to say that if you find yourself spending a lot of time struggling with the script, definitely down be afraid to strip it down, change how it works, or remove it completely. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

2022-01-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. FWIW, I consider the build.py script a failed experiment. The idea itself was not completely bad, but the lack of buy-in from sufficient amount of developers meant that it never really had a chance of fulfilling its (rather lofty) goals. I think it should be removed or

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

2022-01-19 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: JDevlieghere. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch updates toolchain-msvc.test to cater for Arm64 windows platform. https://reviews.llvm.org/D117676 Files: