Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-21 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. Fixed by http://reviews.llvm.org/rL245546 Repository: rL LLVM http://reviews.llvm.org/D11947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-20 Thread Ying Chen via lldb-commits
chying added a subscriber: chying. chying added a comment. It seems a bunch of darwin->android_arm tests are broken after this patch. Could you take a look? Here is the first build after this patch. http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4977/steps/test7/logs/stdio Rep

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-20 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245546: Improve instruction emulation based stack unwinding (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D11947?vs=32395&id=32670#toc Repository: rL LLVM http://review

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-18 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me. http://reviews.llvm.org/D11947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-18 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 32395. tberghammer added a comment. Fix incorrect assert http://reviews.llvm.org/D11947 Files: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp source/Plugins/UnwindAssembly/Inst

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-11 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 31828. http://reviews.llvm.org/D11947 Files: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp Index: so

[Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-11 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: jasonmolenda. tberghammer added a subscriber: lldb-commits. Herald added a subscriber: aemerson. Improve instruction emulation based stack unwinding On ARM there is no difference between a pop and a load instruction so a register ca